{"type":"doc","content":[{"type":"paragraph","content":[{"text":"Which is the best pattern to use in the controller?","type":"text"}]},{"type":"bodiedExtension","attrs":{"layout":"full-width","extensionType":"com.atlassian.confluence.macro.core","extensionKey":"details","parameters":{"macroParams":{"label":{"value":""}},"macroMetadata":{"macroId":{"value":"22e3a16b-2ecf-4847-a9fa-595a416e5550"},"schemaVersion":{"value":"1"},"title":"Page Properties"}}},"content":[{"type":"table","attrs":{"layout":"full-width"},"content":[{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[147.0]},"content":[{"type":"paragraph","content":[{"text":"Status","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[579.0]},"content":[{"type":"paragraph","content":[{"type":"status","attrs":{"color":"green","style":"bold","text":"DONE","localId":"ccf5ddc6-23b1-4e19-8e1f-0b92f5f2e237"}}]}]}]},{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[147.0]},"content":[{"type":"paragraph","content":[{"text":"Impact","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[579.0]},"content":[{"type":"paragraph","content":[{"type":"status","attrs":{"color":"red","style":"bold","text":"HIGH","localId":"5ffa8f7f-ade4-4fe9-b31f-e9bf8ea61320"}},{"text":" ","type":"text"}]}]}]},{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[147.0]},"content":[{"type":"paragraph","content":[{"text":"Driver","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[579.0]},"content":[{"type":"paragraph","content":[{"type":"mention","attrs":{"id":"557058:743ed37a-614a-40ac-b54a-4c5e8da912ac","text":"@Alessandro Domanico"}},{"text":" ","type":"text"}]}]}]},{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[147.0]},"content":[{"type":"paragraph","content":[{"text":"Approver","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[579.0]},"content":[{"type":"paragraph","content":[{"type":"mention","attrs":{"id":"557058:743ed37a-614a-40ac-b54a-4c5e8da912ac","text":"@Alessandro Domanico"}},{"text":" ","type":"text"}]}]}]},{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[147.0]},"content":[{"type":"paragraph","content":[{"text":"Stakeholders","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[579.0]},"content":[{"type":"paragraph","content":[{"type":"mention","attrs":{"id":"557058:a1938d4d-8888-4be2-aaa4-8339d37096c7","text":"@Niccolò Pasquetto"}},{"text":" ","type":"text"},{"type":"mention","attrs":{"id":"557058:3c619fc7-9d4b-4fa0-9813-d2d5642feb88","text":"@Vito Romano"}},{"text":" ","type":"text"},{"type":"mention","attrs":{"id":"557058:5a8cc1fb-656c-45f9-be98-6067c2db01d4","text":"@Antonio Verni"}},{"text":" ","type":"text"},{"type":"mention","attrs":{"id":"557058:83ceaee8-9c1d-42bf-99dd-a5aee01b968b","text":"@Roberto C"}},{"text":" ","type":"text"},{"type":"mention","attrs":{"id":"557058:5f1e639c-38f0-497c-b4f7-18632af15d16","text":"@Riccardo Costa"}},{"text":" ","type":"text"}]}]}]},{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[147.0]},"content":[{"type":"paragraph","content":[{"text":"Informed","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[579.0]},"content":[{"type":"paragraph"}]}]},{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[147.0]},"content":[{"type":"paragraph","content":[{"text":"Due date","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[579.0]},"content":[{"type":"paragraph","content":[{"type":"date","attrs":{"timestamp":"1585094400000"}}]}]}]},{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[147.0]},"content":[{"type":"paragraph","content":[{"text":"Outcome","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[579.0]},"content":[{"type":"paragraph","content":[{"text":"Final pattern in the ","type":"text"},{"text":"Outcome ","type":"text","marks":[{"type":"strong"}]},{"text":"section","type":"text"}]}]}]}]}]},{"type":"heading","attrs":{"level":2},"content":[{"text":"Background","type":"text"}]},{"type":"paragraph","content":[{"text":"The REST API layer is still under design. Different ideas has been proposed up to now, but still we are not sure which is the best one to adopt for the project.","type":"text"}]},{"type":"paragraph","content":[{"text":"Initally, the ","type":"text"},{"type":"inlineCard","attrs":{"url":"https://openhospital.atlassian.net/browse/OP-4"}},{"text":" was proposed. Then the ","type":"text"},{"type":"inlineCard","attrs":{"url":"https://openhospital.atlassian.net/browse/OP-6"}},{"text":" has started and divided into a number of subtasks.","type":"text"}]},{"type":"paragraph","content":[{"text":"One of these subtask (the ","type":"text"},{"type":"inlineCard","attrs":{"url":"https://openhospital.atlassian.net/browse/OP-118"}},{"text":") changed the initial proposal to something different while not yet completed (premature merge) and while other contributors were relying on the initially proposed pattern in other isses (e.g. ","type":"text"},{"type":"inlineCard","attrs":{"url":"https://openhospital.atlassian.net/browse/OP-178"}},{"text":" and ","type":"text"},{"type":"inlineCard","attrs":{"url":"https://openhospital.atlassian.net/browse/OP-127"}},{"text":")","type":"text"}]},{"type":"paragraph","content":[{"text":"So now the point is to adopt one of the two, with an agnostic comparison between different solutions.","type":"text"}]},{"type":"heading","attrs":{"level":2},"content":[{"text":"Relevant data","type":"text"}]},{"type":"bulletList","content":[{"type":"listItem","content":[{"type":"paragraph","content":[{"text":"almost 90% of ModelDTOs in “api” would be identical to Models in “core”","type":"text"}]}]},{"type":"listItem","content":[{"type":"paragraph","content":[{"text":"some ModelDTO (10%) may need a dedicated mapping","type":"text"}]}]},{"type":"listItem","content":[{"type":"paragraph","content":[{"text":"the Swagger documentation need to be coherent with the code ","type":"text"}]}]}]},{"type":"heading","attrs":{"level":2},"content":[{"text":"Options considered","type":"text"}]},{"type":"table","attrs":{"layout":"wide"},"content":[{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[350.0]},"content":[{"type":"paragraph"}]},{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[218.0]},"content":[{"type":"paragraph","content":[{"text":"Option 1:","type":"text"}]}]},{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[218.0]},"content":[{"type":"paragraph","content":[{"text":"Option 2:","type":"text"}]}]},{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[174.0]},"content":[{"type":"paragraph","content":[{"text":"Option 3:","type":"text"}]}]}]},{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[350.0]},"content":[{"type":"paragraph","content":[{"text":"Description","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[218.0]},"content":[{"type":"paragraph","content":[{"text":"Linear mapping","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[218.0]},"content":[{"type":"paragraph","content":[{"text":"Automapping","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[174.0]},"content":[{"type":"paragraph","content":[{"text":"AbstractController","type":"text"}]}]}]},{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[350.0]},"content":[{"type":"paragraph","content":[{"text":"Pros and cons","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[218.0]},"content":[{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-plus","text":":plus:","shortName":":plus:"}},{"text":" doesn’t need more knowledge for Java Base contributors (more linear)","type":"text"}]},{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-minus","text":":minus:","shortName":":minus:"}},{"text":" makes the controllers ticker","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[218.0]},"content":[{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-plus","text":":plus:","shortName":":plus:"}},{"text":" offer a centralized point for models mapping","type":"text"}]},{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-plus","text":":plus:","shortName":":plus:"}},{"text":" can be customized or disabled where not required","type":"text"}]},{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-minus","text":":minus:","shortName":":minus:"}},{"text":" it needs annotations (less linear)","type":"text"}]},{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-minus","text":":minus:","shortName":":minus:"}},{"text":" ","type":"text"},{"text":"it needs adjustments for Swagger documentation","type":"text","marks":[{"type":"strike"}]}]},{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-minus","text":":minus:","shortName":":minus:"}},{"text":" it binds to a 1:1 mapping that may be useless in the future","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[174.0]},"content":[{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-plus","text":":plus:","shortName":":plus:"}},{"text":" it should simplify the writing of a standard controller","type":"text"}]},{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-minus","text":":minus:","shortName":":minus:"}},{"text":" it works only for controllers managing one Model/DTO","type":"text"}]},{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-minus","text":":minus:","shortName":":minus:"}},{"text":" it binds to a 1:1 mapping that may be useless in the future","type":"text"}]},{"type":"paragraph","content":[{"type":"emoji","attrs":{"id":"atlassian-minus","text":":minus:","shortName":":minus:"}},{"text":" it may lead to a “GOD Class” ","type":"text"},{"text":"known problem","type":"text","marks":[{"type":"link","attrs":{"href":"https://wiki.c2.com/?GodClass"}}]}]}]}]},{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[350.0]},"content":[{"type":"paragraph","content":[{"text":"Estimated cost","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[218.0]},"content":[{"type":"paragraph","content":[{"type":"status","attrs":{"color":"green","style":"bold","text":"Small","localId":"31640400-f619-4d91-b85b-b58f5daa7845"}}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[218.0]},"content":[{"type":"paragraph","content":[{"type":"status","attrs":{"color":"green","style":"bold","text":"small","localId":"e6272c68-1197-4d8a-a404-182f0cf189d6"}}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[174.0]},"content":[{"type":"paragraph","content":[{"type":"status","attrs":{"color":"green","style":"bold","text":"SMALL","localId":"ebb0b2d0-f2cb-4e29-be13-e33628b87457"}},{"text":" ","type":"text"}]}]}]}]},{"type":"heading","attrs":{"level":2},"content":[{"text":"Action items","type":"text"}]},{"type":"paragraph","content":[{"text":"These are the proposed steps in order to take a decision","type":"text"}]},{"type":"taskList","attrs":{"localId":""},"content":[{"type":"taskItem","attrs":{"state":"DONE","localId":"1"},"content":[{"type":"mention","attrs":{"id":"557058:5f1e639c-38f0-497c-b4f7-18632af15d16","text":"@Riccardo Costa"}},{"text":" continues with the linear mapping on module “OPD” as per his own OP-118","type":"text","marks":[{"type":"strike"}]}]},{"type":"taskItem","attrs":{"state":"DONE","localId":"2"},"content":[{"type":"mention","attrs":{"id":"5c52bfe7c0567a194bdd7221","text":"@Uni2grow Cameroun"}},{"text":" continues with his own work on the OP-115","type":"text"}]},{"type":"taskItem","attrs":{"state":"DONE","localId":"3"},"content":[{"type":"mention","attrs":{"id":"557058:5a8cc1fb-656c-45f9-be98-6067c2db01d4","text":"@Antonio Verni"}},{"text":" propose a change to the initial pattern in order to make it not exlusive and applying it on other OP-6 unassigned subtasks (e.g. OP-119)","type":"text"}]},{"type":"taskItem","attrs":{"state":"DONE","localId":"4"},"content":[{"type":"mention","attrs":{"id":"557058:3c619fc7-9d4b-4fa0-9813-d2d5642feb88","text":"@Vito Romano"}},{"text":" continues his own work on OP-116 trying using the the change to the initial pattern coming from Antonio","type":"text"}]},{"type":"taskItem","attrs":{"state":"DONE","localId":"6"},"content":[{"text":"Other Contributors","type":"text","marks":[{"type":"strong"}]},{"text":" to feel free to follow one of the two patterns or to propose a different one in their developments","type":"text"}]},{"type":"taskItem","attrs":{"state":"DONE","localId":"5"},"content":[{"type":"mention","attrs":{"id":"557058:743ed37a-614a-40ac-b54a-4c5e8da912ac","text":"@Alessandro Domanico"}},{"text":" To decide the final pattern before the end of March","type":"text"}]}]},{"type":"heading","attrs":{"level":2},"content":[{"text":"Outcome","type":"text"}]},{"type":"paragraph","content":[{"text":"The ","type":"text"},{"text":"final pattern","type":"text","marks":[{"type":"strong"}]},{"text":" approved pattern (temporary but the same for all OP-6 subtasks) is the following and it is implemented here ","type":"text"},{"type":"inlineCard","attrs":{"url":"https://github.com/informatici/openhospital-api/tree/OP-6-new-proposed-pattern"}},{"text":" ","type":"text"}]},{"type":"paragraph","content":[{"text":"/openhospital-api/src/main/java/org/isf/shared/mapper/converter/ModelMapperConfig.java","type":"text","marks":[{"type":"strong"}]}]},{"type":"codeBlock","content":[{"text":"package org.isf.shared.mapper.converter;\n\n@Configuration\npublic class ModelMapperConfig {\n\n @Autowired\n protected BlobToByteArrayConverter blobToByteArrayConverter;\n\n @Autowired\n protected ByteArrayToBlobConverter byteArrayToBlobConverter;\n\n @Bean\n public ModelMapper modelMapper() {\n ModelMapper modelMapper = new ModelMapper();\n modelMapper.addConverter(blobToByteArrayConverter);\n modelMapper.addConverter(byteArrayToBlobConverter);\n return modelMapper;\n }\n}","type":"text"}]},{"type":"paragraph"},{"type":"paragraph","content":[{"text":"/openhospital-api/src/main/java/org/isf/shared/mapper/Mapper.java","type":"text","marks":[{"type":"strong"}]}]},{"type":"codeBlock","content":[{"text":"package org.isf.shared.mapper;\npublic interface Mapper {\n public ToType map2DTO(FromType fromObj);\n public FromType map2Model(ToType toObj);\n public List map2DTOList(List list);\n}","type":"text"}]},{"type":"paragraph","content":[{"text":" ","type":"text"}]},{"type":"paragraph","content":[{"text":"/openhospital-api/src/main/java/org/isf/shared/mapper/GenericMapper.java","type":"text","marks":[{"type":"strong"}]}]},{"type":"codeBlock","content":[{"text":"package org.isf.shared.mapper;\npublic class GenericMapper implements Mapper {\n\n @Autowired\n protected ModelMapper modelMapper;\n private Type sourceClass;\n private Type destClass;\n \n public GenericMapper(Class sourceClass, Class destClass) {\n this.sourceClass = sourceClass;\n this.destClass = destClass;\n }\n \n @Override\n public DestType map2DTO(SourceType fromObj) {\n return modelMapper.map(fromObj, destClass);\n }\n\n @Override\n public SourceType map2Model(DestType toObj) {\n return modelMapper.map(toObj, sourceClass); \n }\n\n @Override\n public List map2DTOList(List list) {\n return (List) list.stream().map(it -> modelMapper.map(it, destClass)).collect(Collectors.toList());\n }\n}","type":"text"}]},{"type":"paragraph","content":[{"text":" ","type":"text"}]},{"type":"paragraph","content":[{"text":"/openhospital-api/src/main/java/org/isf/patient/mapper/PatientMapper.java (example)","type":"text","marks":[{"type":"strong"}]}]},{"type":"codeBlock","content":[{"text":"package org.isf.patient.mapper;\n@Component\npublic class PatientMapper extends GenericMapper {\n\tpublic PatientMapper() {\n\t\tsuper(Patient.class, PatientDTO.class);\n\t}\n}","type":"text"}]},{"type":"paragraph","content":[{"text":" ","type":"text"}]},{"type":"paragraph","content":[{"text":"Then in ","type":"text"},{"text":"/openhospital-api/src/main/java/org/isf/patient/rest/PatientController.java (example)","type":"text","marks":[{"type":"strong"}]}]},{"type":"codeBlock","content":[{"text":"@Autowired\nprotected PatientMapper mapper;\n...\nboolean isCreated = patientManager.newPatient(mapper.map2Model(newPatient));\n...\nList patientDTOS = mapper.map2DTOList(patients);\n...\nreturn ResponseEntity.ok(mapper.map2DTO(patient));\n...","type":"text"}]},{"type":"paragraph"},{"type":"paragraph","content":[{"text":" ","type":"text"}]}],"version":1}

Browser not supported