Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Improve JPA related methods

Description

With the switch to JPA there are many I/O related routines that return values that should be returning void and other routines that should be returning objects.

For example, some routines (e.g., newBillItems() always returns true when it should be returning void. Then there is a routine, updateBill that always returns true despite what the code would have you believe when it should be returning the Bill object.

Here is the javadoc for some of the underlying JPA methods that are driving the changes suggested:

 

There may be some bleed into the GUI and API projects with some of the changes.

The idea is to go small groups of changes to better review and integrate them into the projects. Somethig like one package at at time.

Environment

None

Activity

David B Malkovsky October 1, 2023 at 8:07 PM
Edited

Package

Done

Core PR

accounting

Y

admission

Y

admtype

Y

agetype

Y

anamnesis

Y

dicom

Y

dicomtype

Y

disctype

Y

disease

Y

distype

Y

dlvrrestype

Y

dlvrtype

Y

exa

Y

examination

Y

exatype

Y

hospital

Y

lab

Y

malnutrition

Y

medicals

Y

medicalstock

Y

medicalstockward

Y

medstockmovtype

Y

medtype

Y

menu

Y

opd

Y

operation

Y

opetype

Y

patconsensus

Y

patient

Y

patvac

Y

permissions

Y

pregtreattype

Y

priceslist

Y

pricesothers

Y

sessionaudit

Y

sms

Y

supplier

Y

therapy

Y

vaccine

Y

vactype

Y

visits

Y

ward

Y

Done

Details

Assignee

Reporter

Labels

Components

Fix versions

Original estimate

Time tracking

5h 15m logged5w 4d 2h 45m remaining

Sprint

Priority

Created September 25, 2023 at 5:26 PM
Updated January 7, 2024 at 9:57 PM
Resolved December 15, 2023 at 1:15 PM