| Table of Contents | ||||||
|---|---|---|---|---|---|---|
|
1. Fork
Wherever you want to Implement implement a new feature or Fix to fix a bug (see below) the best the only way to work with us contribute is to fork the project in your userspace (in GitHub is called https://github.com/<username>) and to Pull-Request on from an ad-hoc branch different from the 'develop'.
In order to fork, go to the component’s page of your interest and click on "Fork" on the right-top.
...
Components Open Hospital components are:
Issues generally contain indication indications about exactly “which” components will be affected
...
In this way, your developments will be automatically linked to Jira, and also issues’codes typed in GitHub will be converted into links to Jira’s pages.
...
NOTE: use the same branch name for all repositories involved in the issue
4. Code
On your "forked-and-cloned-then-branched" you can commit as many times you want, please follow the 'gold rules' below.
Check our Coding Chips!
Double analyze the existing code, don't write what is already written, be DRY (Don't Repeat Yourself)
Dumb code is better than clever one when is time to share
Write comments when only "YOU" know what you are doing
Optimize only after achieved
Less is more!
...
Insert a thorough description in the Pull Request, indicating again the issue code (to ease easy link to Jira issue’s page), some useful info and whereas the PR is linked to another PR on another component.
...
7. Communicate
Comments Comment and ask under on the Jira issue’s page about suggestions, reasoningreasonings, findings and for to update the community about your job. Be respectful and foster others in sharing their thoughts.
...
Very important, keep an eye con review on reviews and comments about on your Pull Requests pages.
A Pull Request will NOT be merged (appliedwelcomed) until there will be unsersolved unresolved conversations.
...
Keep also an eye on new developments landing on the component’s develop (default) branch and periodically resync your fork!
For more info see Git fork syncing (polish your work)
...