Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

JUnit Tests for Core admtype and agetype packages

Description

Increase JUnit test coverage for Core admtype and agetype packages.

Environment

None

Attachments

3

Activity

Alessandro Domanico December 1, 2020 at 10:54 PM

Thanks for the answers; we could discuss tests methods naming convention in another issue.

Thanks for , I will revise it ASAP

David B Malkovsky December 1, 2020 at 11:25 AM

Re: test naming; the old style required the word “test” to start the method name; now the “@Test” annotation is used. So I’ve dropped the “test” and prefixed the tests with “mgr” for those that test the “Manager” classes; where the other ones have “IO” in them for the “IO” type tests.

As for bumping the assertj version I needed it to the test the return array from the “validation” method tests. When spring is bumped up to be more recent then this shouldn’t be necessary.

Alessandro Domanico November 28, 2020 at 9:57 AM
Edited

Merged! Thanks a lot!

BTW, why the need to bump assertj to 3.18.1 even if only for test? Just wondering if there are some specific need for the tests we are writing.

Also, do you think about to adopt a commont naming for tests?

Done

Details

Assignee

Reporter

Labels

Components

Fix versions

Time tracking

1h 30m logged

Parent

Priority

Created November 26, 2020 at 5:18 PM
Updated February 29, 2024 at 9:47 AM
Resolved December 1, 2020 at 11:03 PM